Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential underflow / overflow when converting from float to int16 #209

Open
Meoo opened this issue Aug 10, 2022 · 1 comment
Open

Potential underflow / overflow when converting from float to int16 #209

Meoo opened this issue Aug 10, 2022 · 1 comment

Comments

@Meoo
Copy link

Meoo commented Aug 10, 2022

In the example code "rnnoise_demo", the float output is converted to a short with a simple cast

I found by experimentation that the output can be outside of int16 range, so the output should be clamped to prevent clicky noises when the input has values near the int16's min or max

@lufengjie051523
Copy link

Hi,did you solved the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants