Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When to update the xi-editor submodule? #342

Open
mmatoszko opened this issue Nov 9, 2018 · 1 comment
Open

When to update the xi-editor submodule? #342

mmatoszko opened this issue Nov 9, 2018 · 1 comment

Comments

@mmatoszko
Copy link
Member

mmatoszko commented Nov 9, 2018

Since xi-editor is a submodule of xi-mac now, we might need to establish a process of updating the commit of the subproject in the xi-mac repo.

If the subproject commit hash won't get updated people who clone the project using
git clone --recurse-submodules https://github.com/xi-editor/xi-mac might be using older version of xi-editor, and this might cause some unexpected issues.

@mmatoszko mmatoszko changed the title When to update the xi-core submodule? When to update the xi-editor submodule? Nov 10, 2018
@cmyr
Copy link
Member

cmyr commented Nov 10, 2018

Yep this is a good question.

  • We could say that any PR to xi-mac should update xi-editor if it's behind
  • We could update xi-editor 'as needed', say every week or so

Certainly any time feature support is being added to xi-mac, the xi-editor revision should be updated to include the new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@mmatoszko @cmyr and others