Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resultions for sanitize.css #506

Open
marziolek opened this issue Sep 15, 2021 · 4 comments
Open

Resultions for sanitize.css #506

marziolek opened this issue Sep 15, 2021 · 4 comments
Assignees

Comments

@marziolek
Copy link

package.json needs
"resolutions": {
"sanitize.css": "12.0.1"
},

edenizk added a commit to edenizk/generator-chisel that referenced this issue Sep 19, 2021
@edenizk
Copy link
Contributor

edenizk commented Sep 19, 2021

Hi @luboskmetko,

I have added the sanitize.css to the resolutions you can see in this PR. There is one problem, it will create a problem for ppl who are not using yarn because npm doesn't support "resolutions".
Some solutions I've found is using this package for converting resolutions for npm users https://www.npmjs.com/package/npm-force-resolutions
or using this script from https://newbedev.com/npm-equivalent-of-yarn-resolutions.
Unfortunately, in my opinion, these are not elegant solutions. You need to run for example npm update-resolutions, after each npm i.

In the new version of Postcss-normalizer, they have solved the issue. As I remember, we need to have postcss version 8 for the update. In the update-dep(#500) task, I've updated that, and this problem will be resolved when we merge the update 🙂

@jakub300
Copy link
Collaborator

@edenizk could you create a issue in postcss-normlize asking to backport the fix to v9 csstools/postcss-normalize#60 ?

@edenizk
Copy link
Contributor

edenizk commented Sep 27, 2021

@jakub300, I think this is a related issue csstools/postcss-normalize#62

@jakub300
Copy link
Collaborator

Hi all, I created @jakub300/postcss-normalize that should work fine and released new chisel version (generator-chisel@1.0.0-alpha.13)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants