Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep_original_order does not work for stan fit objects #74

Open
Videodr0me opened this issue Jul 3, 2021 · 1 comment
Open

keep_original_order does not work for stan fit objects #74

Videodr0me opened this issue Jul 3, 2021 · 1 comment

Comments

@Videodr0me
Copy link

Videodr0me commented Jul 3, 2021

Bug/Inconsistent Behaviour: the keep_original_order option does not work for stan fit objects.

Please fix, as this is very awkward if you want to group certain parameters together in a specific order for example in two column plots. Even better would be if the family order (sequence in which the variables are named in the family string) can optionally be preserved. This would allow to choose between ordering alphabetically, keeping the fit objects ordering or imposing the family string order. The latter wouold give a lot of flexibility without rerunning the monte carlo sim.

@Videodr0me
Copy link
Author

I think the absolute simplest solution would be to allow two alternative parameters: current behaviour with a regexp string as parameter, and altenatively a list of parameter names where order is preserved. This should be pretty straightforward as these are different data-types so whenever a list is passed to ggmcmc its assumed that the list items are supposed to be exact matches where order of that list is preserved.

Even better would be if the list items could be regexp themselves, that would be the best of both worlds, then you could manually order parameters and still use regexp to include a bunch of similar or indexed parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant