Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme #2149

Open
rakleed opened this issue Apr 18, 2023 · 3 comments
Open

Dark theme #2149

rakleed opened this issue Apr 18, 2023 · 3 comments

Comments

@rakleed
Copy link

rakleed commented Apr 18, 2023

It would be nice to have a dark theme in the Xenia. Because using it at night or in a dark room is very unpleasant because of the bright white background. Ideally, it would be good if the theme of Xenia matches the theme of the system.

@Triang3l
Copy link
Member

The contents of the window on launch are black now, it looks like you're using some extremely outdated (pre-early-2022) version. However, there's nothing to apply themes to so far, as the UI currently only contains a thin menu bar in the top, which is a standard Win32 menu. DWMWA_USE_IMMERSIVE_DARK_MODE, unfortunately, only controls the color of the title bar, but not the menu.

@rakleed
Copy link
Author

rakleed commented Apr 18, 2023

@Triang3l yeah, but still, the background where the game starts is not the whole application interface. Therefore, my request refers specifically to the title bar and menu items.

Screenshot

image

What do you think about the dark theme implementation of Notepad++? notepad-plus-plus/notepad-plus-plus@5a3bf49

@Triang3l
Copy link
Member

If the dark mode requires hard-coding any specific RGB colors in Xenia, I don't think it'd be the right way to go (not friendly to system configuration, to the user's Windows theme) when using the OS's controls if they don't support the dark mode internally.

Though anyway, this whole GUI is slooowly being replaced with a completely new frontend, which is dark by default, so it's on life support overall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants