Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit #24064 breaks Bluray folder library addition and playback #25184

Closed
1 of 7 tasks
78andyp opened this issue May 10, 2024 · 3 comments · Fixed by #25193
Closed
1 of 7 tasks

Commit #24064 breaks Bluray folder library addition and playback #25184

78andyp opened this issue May 10, 2024 · 3 comments · Fixed by #25193
Labels
Resolution: Fixed issue was resolved by a code change v22 "P"

Comments

@78andyp
Copy link
Contributor

78andyp commented May 10, 2024

Bug report

Describe the bug

I was testing and have found a recent issue adding a BMDV folder.
Using the current master all the files and folders get processed - resulting in multiple Playback entries etc..

image

Using git bisect the issue seems to be #24064.

Looking at the code it seems that HAVE_LIBBLURAY is not being set and hence the BDMV folders/files aren't being properly filtered by GetOpticalMediaPath

  const auto files = std::array{
      "VIDEO_TS.IFO"s,    "VIDEO_TS/VIDEO_TS.IFO"s,
#ifdef HAVE_LIBBLURAY
      "index.bdmv"s,      "INDEX.BDM"s,
      "BDMV/index.bdmv"s, "BDMV/INDEX.BDM"s,
#endif

I think it also breaks bluray playback as well.

Sorry @fuzzard, I don't understand CMAKE to offer anything further.

Thanks
Andy

Expected Behavior

Here is a clear and concise description of what was expected to happen:

Blurays scan/play properly.

Actual Behavior

As above.

Possible Fix

HAVE_LIBBLURAY needs setting.

To Reproduce

Steps to reproduce the behavior:

As above.

Debuglog

The debuglog can be found here:

https://paste.kodi.tv/ucowiruqam.kodi
(I had to chop some from the middle as too big - all repetative)

Screenshots

Here are some links or screenshots to help explain the problem:

Above

Additional context or screenshots (if appropriate)

Here is some additional context or explanation that might help:

Your Environment

Used Operating system:

  • Android

  • iOS

  • tvOS

  • Linux

  • macOS

  • Windows

  • Windows UWP

  • Operating system version/name:

  • Kodi version:

note: Once the issue is made we require you to update it with new information or Kodi versions should that be required.
Team Kodi will consider your problem report however, we will not make any promises the problem will be solved.

@xbmc-gh-bot xbmc-gh-bot bot added the Triage: Needed (managed by bot!) issue that was just created and needs someone looking at it label May 10, 2024
@78andyp 78andyp changed the title Commit #24064 breaks Bluray folder library addition Commit #24064 breaks Bluray folder library addition and playbakc May 10, 2024
@78andyp 78andyp changed the title Commit #24064 breaks Bluray folder library addition and playbakc Commit #24064 breaks Bluray folder library addition and playback May 10, 2024
@fuzzard
Copy link
Contributor

fuzzard commented May 10, 2024

Could you test the following fuzzard@2f105b4

@78andyp
Copy link
Contributor Author

78andyp commented May 10, 2024

Thanks for looking. Sorry, doesn't work. I assume I just needed to buildsetup nobinaryaddons clean and not anything more.

@fuzzard
Copy link
Contributor

fuzzard commented May 10, 2024

Will need info/logs from the actual build/configure.

CMakeCache.txt and just the output of the cmake configure step .

Feel free to DM/ping me on slack

@thexai thexai added Resolution: Fixed issue was resolved by a code change v22 "P" and removed Triage: Needed (managed by bot!) issue that was just created and needs someone looking at it labels May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Fixed issue was resolved by a code change v22 "P"
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants