Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the mentioned pylint errors to get perfect 10. (useless-else-on-loop, too-many-nested-blocks) #185

Open
LordGameleo opened this issue Mar 19, 2019 · 2 comments

Comments

@LordGameleo
Copy link
Contributor

LordGameleo commented Mar 19, 2019

We are currently using a customized checklist for pylint. We have disabled a lot of checks to make our build successfully. We want to counter these checks few at a time. This issue deals with one of them.

How to produce:

After forking and cloning this repo, make a branch named develop-Pylint_Issue#185 using
git branch develop-Pylint_Issue#185

Checkout branch by
git checkout develop-Pylint_Issue#185

remove useless-else-on-loop and too-many-nested-blocks from .pylintrc file

Check pylint errors using
pylint * on terminal (in the repo)

Add doc strings to get a perfect 10 score on pylint.

@LordGameleo LordGameleo changed the title Correct the mentioned pylint errors to get perfect 10. (broad-except, too-many-nested-blocks, inconsistent-return-statements,, useless-else-on-loop, too-many-nested-blocks, inconsistent-return-statements) Correct the mentioned pylint errors to get perfect 10. (broad-except, too-many-nested-blocks, inconsistent-return-statements, useless-else-on-loop, too-many-nested-blocks, inconsistent-return-statements) Mar 19, 2019
@LordGameleo LordGameleo changed the title Correct the mentioned pylint errors to get perfect 10. (broad-except, too-many-nested-blocks, inconsistent-return-statements, useless-else-on-loop, too-many-nested-blocks, inconsistent-return-statements) Correct the mentioned pylint errors to get perfect 10. (broad-except, too-many-nested-blocks, useless-else-on-loop, too-many-nested-blocks) Mar 19, 2019
@LordGameleo LordGameleo changed the title Correct the mentioned pylint errors to get perfect 10. (broad-except, too-many-nested-blocks, useless-else-on-loop, too-many-nested-blocks) Correct the mentioned pylint errors to get perfect 10. (broad-except, useless-else-on-loop, too-many-nested-blocks) Mar 19, 2019
@shrawnz
Copy link
Contributor

shrawnz commented Mar 19, 2019

Hi, I'd like to pick up this issue

@LordGameleo
Copy link
Contributor Author

@shrawnz Yeah feel free to work on this one. Remember to deal with one of these check at once. Separate different checks by using separate commits.

@Rechi Rechi changed the title Correct the mentioned pylint errors to get perfect 10. (broad-except, useless-else-on-loop, too-many-nested-blocks) Correct the mentioned pylint errors to get perfect 10. (useless-else-on-loop, too-many-nested-blocks) Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants