Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError in check_for_existing_addon #147

Open
tadly opened this issue Nov 22, 2018 · 5 comments
Open

TypeError in check_for_existing_addon #147

tadly opened this issue Nov 22, 2018 · 5 comments

Comments

@tadly
Copy link
Member

tadly commented Nov 22, 2018

Occurred with this PR.

For searchability here the traceback:

The command "if [ "$TRAVIS_PULL_REQUEST" = "false" ]; then kodi-addon-checker --branch=jarvis; fi" exited with 0.

$ if [ "$TRAVIS_PULL_REQUEST" != "false" ]; then kodi-addon-checker --branch=jarvis --PR $(git diff --diff-filter=d --name-only HEAD~ | grep / | cut -d / -f1 | sort | uniq); fi
INFO: Checking add-on service.linuxwhatelse.notify
INFO: Created by linuxwhatelse
INFO: Addon id matches folder name
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.6.3/bin/kodi-addon-checker", line 11, in <module>
    sys.exit(main())
  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/kodi_addon_checker/__main__.py", line 89, in main
    report.add(check_artifact(directory, args, args.branch, all_repo_addons, args.PR))
  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/kodi_addon_checker/__main__.py", line 55, in check_artifact
    return check_addon.start(artifact_path, branch_name, all_repo_addons, pr, config)
  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/kodi_addon_checker/check_addon.py", line 49, in start
    check_old_addon.check_for_existing_addon(addon_report, addon_path, all_repo_addons, pr)
  File "/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages/kodi_addon_checker/check_old_addon.py", line 31, in check_for_existing_addon
    if addon_name in repo_addons:
TypeError: argument of type 'NoneType' is not iterable
The command "if [ "$TRAVIS_PULL_REQUEST" != "false" ]; then kodi-addon-checker --branch=jarvis --PR $(git diff --diff-filter=d --name-only HEAD~ | grep / | cut -d / -f1 | sort | uniq); fi" exited with 1.

Done. Your build exited with 1.
@mzfr
Copy link
Contributor

mzfr commented Dec 9, 2018

This is a bit weird. This will only happen if repo_addons will be None. And repo_addons shouldn't be None.

Did we get this kind of error somewhere else also?

@mzfr
Copy link
Contributor

mzfr commented Dec 10, 2018

Getting the same error here: https://travis-ci.org/xbmc/addon-check/jobs/466062485

@LordGameleo
Copy link
Contributor

@mzfr are you working on this issue?

@mzfr
Copy link
Contributor

mzfr commented Mar 9, 2019

You can work on this issue of you want

@LordGameleo
Copy link
Contributor

@mzfr would you mind briefing me about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants