Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SPDX-License-Identifier for add-ons as well #126

Open
MartijnKaijser opened this issue Oct 13, 2018 · 6 comments · May be fixed by #144
Open

Use SPDX-License-Identifier for add-ons as well #126

MartijnKaijser opened this issue Oct 13, 2018 · 6 comments · May be fixed by #144

Comments

@MartijnKaijser
Copy link
Member

For Kodi code we have switched to the SPDX-License-Identifier which makes it easier to identify what licenses are used. Perhaps this is a good idea as well for add-ons. Just as a suggestion for the dev but not make it mandatory.

@mzfr
Copy link
Contributor

mzfr commented Oct 15, 2018

Is there any addon that has already used SPDX-License-Identifier in their LICENSE.txt?

@MartijnKaijser
Copy link
Member Author

MartijnKaijser commented Oct 25, 2018

There's currently none yet however it's pretty straightforward
Here's a list of identifiers
https://spdx.org/licenses/
For addons they should use something like
<license>GPL-2.0-or-later</license>
in the addon.xml and in the python file itself

Copyright (C) 2005-2018 Team Kodi
This file is part of Kodi - https://kodi.tv

SPDX-License-Identifier: GPL-2.0-or-later
See LICENSES/README.md for more information.

We should also encourage that this is added to every python file.
It should only be a warning/suggestion.

@mzfr
Copy link
Contributor

mzfr commented Nov 2, 2018

@MartijnKaijser by GPL-2.0-or-later you mean GNU GENERAL PUBLIC LICENSE Version 2, June 199 right?
Also since License will stay same forever,Will hardcoding the License text be a problem?

@Rechi
Copy link
Member

Rechi commented Nov 14, 2018

IMO license tag in addon.xml should be made mandatory before warning about python files which miss a SPDX-License-Identifier-

@razzeee
Copy link
Member

razzeee commented Jan 20, 2019

I'm with rechi here, and we need to document this in the wiki first

@anxdpanic
Copy link
Member

If add-ons are needed to test against, plugin.video.youtube, plugin.video.twitch and script.module.python.twitch are all using SPDX license identifiers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants