Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest to use new settings.xml layout for v18 and up #127

Open
MartijnKaijser opened this issue Oct 13, 2018 · 6 comments
Open

Suggest to use new settings.xml layout for v18 and up #127

MartijnKaijser opened this issue Oct 13, 2018 · 6 comments

Comments

@MartijnKaijser
Copy link
Member

Since several version we support a new settings.xml format which is the same as Kodi itself uses.
As most bugs should have been solved by now we should suggest developers to start using this new layout.
I'm sure there is already some wiki page or forum post explaining how the new layout works

@basrieter
Copy link
Contributor

I don't know if we have a page for the new settings for add-ons. If we have one, I would be interested to check whether it contains all info for add-on devs to migrate.

@mzfr
Copy link
Contributor

mzfr commented Oct 13, 2018

@MartijnKaijser
Copy link
Member Author

@mzfr
Copy link
Contributor

mzfr commented Oct 13, 2018

Do we need to check something specific within the file or do we just want to check whether its present or not?

@MartijnKaijser
Copy link
Member Author

Correct:
old format
https://github.com/xbmc/xbmc/blob/master/addons/metadata.themoviedb.org/resources/settings.xml
new format
https://github.com/xbmc/xbmc/blob/master/system/settings/settings.xml

So you need to detect some specific things that identify it as old or new layout

@enen92
Copy link
Member

enen92 commented Oct 16, 2018

A better approach would be to create schemas for all elements in the settings similarly to what we have done for addon xml and just validate that. We have yet to document the new settings format too. Depending on time constraints I may have a look at doing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants