Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XAPI could store reference to block-device as by-(uu)id when presented an enumeration-dependant dev path #5479

Open
ydirson opened this issue Feb 28, 2024 · 0 comments

Comments

@ydirson
Copy link
Contributor

ydirson commented Feb 28, 2024

When a user creates a SR using an enumeration-dependent dev path (eg. /dev/nvme2n1), this creates an opportunity for things to go wrong whenever enumeration order changes, which can be mitigated by using symlinks from /dev/disks/by-id/ or /dev/disks/by-uuid/ instead.

It seems be a good thing to add some protection against those enumeration-dependent dev path. There would be several options, like:

  • just rejecting them (unless some "I know what I'm doing" flag is also given)
  • looking up a more stable path and use it (unless some "I know what I'm doing" flag is also given)

Would there be any problems with such a change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant