Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardcoded path to igmp_query_injector.py #5446

Open
ydirson opened this issue Feb 9, 2024 · 2 comments
Open

hardcoded path to igmp_query_injector.py #5446

ydirson opened this issue Feb 9, 2024 · 2 comments

Comments

@ydirson
Copy link
Contributor

ydirson commented Feb 9, 2024

gmp_query_injector.py install location can be parametrized, but the caml code will only ever look at it in a single place, which does not match the default install location of /usr/lib/xenopsd/

Makefile:       install -D ./ocaml/xenopsd/scripts/igmp_query_injector.py $(DESTDIR)/$(XENOPSD_LIBEXECDIR)/igmp_query_injector.py
ocaml/networkd/lib/network_utils.ml:let inject_igmp_query_script = ref "/usr/libexec/xenopsd/igmp_query_injector.py"
ocaml/xenopsd/xc/xc_resources.ml:  ref "/usr/libexec/xenopsd/igmp_query_injector.py"
@ydirson ydirson changed the title hardcoded path /usr/libexec/xenopsd/igmp_query_injector.py hardcoded path to igmp_query_injector.py Feb 9, 2024
@psafont
Copy link
Member

psafont commented Mar 26, 2024

The default value has never been used by xenserver, there's been a mistmatch since its introduction: xapi-project/xenopsd@056854d#diff-90d08e583c4c9c6f391b2ae90f819f600a6326928ea9512c9e0c6d98e9f29ac2R21

Easiest way to deal with it is to change the value in configure.ml to match the one used in xenserver

@ydirson
Copy link
Contributor Author

ydirson commented Apr 4, 2024

Easiest way to deal with it is to change the value in configure.ml to match the one used in xenserver

Yes, but that would only fix part of the problem - should it be made non-configurable as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants