Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warp/mirror effect does not render correctly on custom models #4353

Open
TheMonks opened this issue Feb 16, 2024 · 4 comments
Open

Warp/mirror effect does not render correctly on custom models #4353

TheMonks opened this issue Feb 16, 2024 · 4 comments

Comments

@TheMonks
Copy link

TheMonks commented Feb 16, 2024

NOTE: IF YOU DO NOT ATTACH A SEQUENCE THAT DEMONSTRATES YOUR PROBLEM THEN THERE IS A HIGH PROBABILITY YOUR ISSUE WILL JUST BE CLOSED AND NOT INVESTIGATED.

Describe the bug
Placing a Warp effect with the type of "mirror" does not render correctly on my custom matrix. I'm not sure if it's due to the atypical wiring pattern or what exactly but it seems like it only occurs when warping on top of a spiral effect.

To Reproduce
Steps to reproduce the behavior:
(and/or link to a short video showing the problem with audio track describing what you are doing)

  1. Load the attached ZIP (Shut Up and Dance from this year's XLAW), render.
  2. Scroll down to the Tri Matrix (not the group but the individual prop w/ 13 layers)
  3. Click on the Warp effect starting at 18.925
  4. See the bars effects mirror just fine, but then the spiral effects have this weird striping pattern in them. The effects on the Tri Matrix are the exact same as on the garage matrix, so the two should look identical.
  5. Note that removing the Warp effect removes the striping issue so seems to revolve around that effect. To get around this for the year, I just made an MP4 of the garage and played that on the Tri Matrix (I left it on the Rows submodel in the ZIP below, FYI) but this work around is not great if I wanted to edit any part of the Tri Matrix at all for the duration of the song.

Expected behavior
The Tri Matrix should behave exactly as the Garage Matrix does.

Screenshots
https://youtu.be/zpBqDXIKpUA

Versions (please complete the following information):

  • OS: Windows 10
  • xLights version 2023.20

Additional context
Add any other context about the problem here.

Attachments
https://www.dropbox.com/scl/fi/g9ceh2pnq6uqoyghvd9lw/Shut-Up-and-Dance-Bad-Ex.zip?rlkey=3ut168h2hxj6hl4ozwq7tstes&dl=0

If you would prefer not to post your sequences publicly please say so and be ready to PM them to one of the developers when asked.

@cybercop23
Copy link
Collaborator

okay.. that's a new one. when i click on the warp effect in your setup i'm crashing... constantly
did an export and import of the 2 models and a test import of the sequence with only the effects for that time slice. seems they match. so must be something else on the tri or group that's affecting it. Try attached.
test.xsq.zip

@derwin12
Copy link
Collaborator

C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.39.33519\include\vector(1894) : Assertion failed: vector subscript out of range
Unhandled exception at 0x00007FFFACB7829C (ucrtbased.dll) in Xlights.exe: An invalid parameter was passed to a function that considers invalid parameters fatal.

This is the single strand effect in the stack ..
image

@TheMonks
Copy link
Author

That's strange that you're crashing. I tried the ZIP you sent and it renders fine, but it only has pinwheels under the warp, you got the effects that end at 18.925. The spirals under the warp don't actually start until 25.85, I just used the previous start time because then you can see the bars under the warp actually working.

I noticed w/ your ZIP file you're on Mac, not sure if that has anything to do with your crash.

Using just my layout, what happens if you import the original work from XLAW and then just map the Matrix 1 effects to my Tri Matrix?

https://drive.google.com/file/d/1vf7nW4xUJ0-3m0T2jWlJTUsXR3yKbcIs/view?usp=drive_link

@derwin12
Copy link
Collaborator

The crash is related to the SS effect. The root cause for this warp effect is something else. We played around with it.
The rotate 90 of the spiral is bringing a row of "black" into the mix. Also set the spiral to per preview helps quite a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants