Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculation of model amp usage in visualizer incorrect either for kulp or falcon either at model or port depending on controller #4315

Open
sidelights opened this issue Feb 6, 2024 · 0 comments

Comments

@sidelights
Copy link

NOTE: IF YOU DO NOT ATTACH A SEQUENCE THAT DEMONSTRATES YOUR PROBLEM THEN THERE IS A HIGH PROBABILITY YOUR ISSUE WILL JUST BE CLOSED AND NOT INVESTIGATED.

Describe the bug
A Falcon does not create virtual strings for a model that does not have a model brightness set (assumed to take port brightness) in all other cases. A kulp however does create virtual strings for each model.

Placing a model at 100% brightness on a kulp or a falcon with a (default port brightness of 30%) in the middle of two props at default brightness results in a total amp estimate on the port that is either wrong for a kulp (because 30% is used for both the first and last model), or Incorrect at the prop level for 3 model in the chain in the popup.

10 pixels (no model brightness set)
10 pixels at 100% at model level
10 pixels (no model brightness set)

For a falcon this would result in a total estimated amp on the port being 1.27 amps
.17 (30% ) + .55 (100%) + .55 (100% because chained, no virtual strings created). 3rd model in the chain however this does not show up as .55 in the popup for the 3rd model in the chain, it shows up as .17 (what it would be if virtual strings at created).

For a kulp based the model level calculation would be correct however at the port level it would using .89 instead of 1.27 amps because of virtual strings thereby being overestimated.

To Reproduce
create 3 models 2 with no model brightness set, 1 with 100% brightness, set controller default port brightness to 30%. Place models on the same port, with the 100% brightness model in the middle.

Compare the totals at the model and port in the popups.

Expected behavior
Calculate port and model brightness based on how the controllers actually function. Adjust estimated amp draw for a model chained for a falcon, adjust the port amp draw correctly for how a kulp operates.
amp_usageIncorrect - Copy

Screenshots
If applicable, add screenshots to help explain your problem.

Versions (please complete the following information):
Windows 11
Xlights 2024.2

Additional context
null sequence created to get an example show folder with 2 controllers and models setup for this example.

Attachments

  • If associated with a crash please attach/link to a dropbox containing the crash log that was produced
  • If it crashed but no crash log was produced please use Tools Menu/Package Logs and attach/link to a dropbox containing the resulting zip file
  • If the error relates to rendering an effect or a crash while sequencing please use Tools Menu/Package Sequence and attach/link to a dropbox containing the resulting zip file

If you would prefer not to post your sequences publically please say so and be ready to PM them to one of the developers when asked.
null_Sequence.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants