Removing object from group in base directory does not update show directory

[TheMonks]

NOTE: IF YOU DO NOT ATTACH A SEQUENCE THAT DEMONSTRATES YOUR PROBLEM THEN THERE IS A HIGH PROBABILITY YOUR ISSUE WILL JUST BE CLOSED AND NOT INVESTIGATED.

Describe the bug
Removing an object from a group while in the base directory, I then go back to the show directory, hit "Update" and yet that object remains in the group.

To Reproduce
Steps to reproduce the behavior:
(and/or link to a short video showing the problem with audio track describing what you are doing)

1. While in your show directory, find a group with a object you need to remove.
2. Navigate to your base directory
3. Remove said object from your base directory and Save.
4. Navigate back to show directory, click "Update" and Save from the base directory.
5. Click on group and object remains.

Expected behavior
I would assuming that removing an item in the base would propagate to the show directory once it is updated.

Screenshots
This is after I removed the "GE Rosa Grande..." group from my group (didn't want to have a group within my group). I'd gone into the base, removed it, and added the two "Torch Long Fixed" submodels and updated back in my show directory but saw this:

Also, in doing this a few times, I've had a large number of crashes when I then go and reload the sequence I've been working on. Will add a ZIP of one of the crashes.

Versions (please complete the following information):

• OS: Windows 10
• xLights version 2023.19 64 bit

Additional context
Add any other context about the problem here.

Attachments
https://www.dropbox.com/scl/fi/a6wuj339fnvjinr1e64yk/xLights_dbgrpt-24124-20231117T215908.zip?rlkey=84rb8orwma3ye1mbasjoggs2d&dl=0

[TheMonks]

Also just noticed, but I couldn't import new singing faces to a sequence (b/c was in show directory) so I'd have to import the entire file in base just to get the face to copy it to my show directory. Which I tried to do but also caused a crash: https://www.dropbox.com/scl/fi/rh26kzpfbbf37oeifjxjl/xLights_dbgrpt-21424-20231118T004627.zip?rlkey=ycwiyjvmo9g4o63tu10q3iwl4&dl=0

[cybercop23]

@TheMonks is this still an issue? I use base folders and I don't have this issue. I think it was a problem, but later fixed.
If fixed, please close this.

[TheMonks]

Hey Alex, I haven't updated since the Xmas season started so for me, yes it is still happening.  After I get my Vday stuff done I'll update and see if it's still happening. Thanks, Eric On Sunday, January 28, 2024 at 10:23:44 AM CST, AlexB ***@***.***> wrote: @TheMonks is this still an issue? I use base folders and I don't have this issue. I think it was a problem, but later fixed. If fixed, please close this. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

[AzGilrock]

I had never messed with the Base Show folder functionality. I just created a base show folder and child show folder as an experiment. Its failing exactly like he says. I deleted a model in the base and its still there in the child show even after hitting update. I also noticed that I can delete base show models while in the child show. Doesn't seem like I should be allowed to do that.

[AzGilrock]

I would work on fixing this but we really never coordinated what our goals are for Base show folders. I feel like we need a set of requirements for it.

[cybercop23]

Thanks @AzGilrock . I see it is removed from the xlights_rgbeffects.xml in base folder but the "show" folder still has it listed and flagged as FromBase=1. I'll poke around too to see if I can find the issue.

[AzGilrock]

My question is do we want everything in the base to be "locked" so that it can't be altered or deleted?

[cybercop23]

"want" is a stong statement, but that's my understanding of what Keith was trying to do. Anything that comes from the base folder can't be managed in the current show folder. You can't move, can't lock (already locked), can't edit - faces, states, sub-models. Once you right click and unlink it, then it becomes local and can do anything you want.
There is a related issue I had found.... if you select multiple models from base folder, you can bulk edit them - I don't think that's intended - it breaks the logic above.

Groups are a little different since it allows you to add local show folder models to base folder groups. But this could be a problem if you end up deleting group from base. You'll loose more than the base n your show folder if you added local models.

Maybe we can handle the delete issue and start a discussion on what/how to enhance base show.

[AzGilrock]

I'm in the child show folder and I select a model and the boundary box is purple indicating its from the base folder. I hit the Delete key on the keyboard. It prompts and says would you like to delete the model?....Yes....boom its gone.

[cybercop23]

Now Update from base... boom.. its back :)

[AzGilrock]

So its a bug

[AzGilrock]

We need "strong" statements. That's what requirements are supposed to be so that different developers wouldn't code it 10 different ways.

[AzGilrock]

I did a little more testing and apparently we allow "locked" models to be deleted. I think we should prevent that and force the user to do an unlock before they could be deleted and base models would not be able to be unlocked.

[cybercop23]

@AzGilrock I think these are somewhat related to "cleaning-up" the base folder functionality. Maybe they can be done together? #4298

[cybercop23]

Found abother one that seems to be the same.. maybe this fix will also fix that one.... #4265