Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add previous and next buttons to navigate longer queries #611

Closed
wants to merge 0 commits into from
Closed

add previous and next buttons to navigate longer queries #611

wants to merge 0 commits into from

Conversation

Lazy-poet
Copy link
Collaborator

@Lazy-poet Lazy-poet commented Jul 12, 2022 •
edited

This PR fixes #592

@yannickwurm yannickwurm mentioned this pull request Jul 28, 2022
Open
@yannickwurm
Copy link
Member

Thanks @Lazy-poet - can we have tests for this as well?

@yannickwurm
Copy link
Member

yannickwurm commented Jul 31, 2022 •
edited

Three additional things:

  • it doesn't "know" where it is. If I scroll down to the 10th one, then hit next, it takes me to the 2nd rather than the 11th.
  • The "previous" should not be shown if we are at the top of the page. The "next" should not be shown if we've passed the last one. (i.e. not shown - and the | not shown either - rather than simply disabling).
  • I think we want a bit more vertical space here too. It looks imbalanced compared to what's happening at Download section of the sidebar. Screenshot 2022-07-31 at 22 50 47
  • Automated test of the transition - when do we have the full index, and when do we show previous/next buttons.
  • Automated test of the scrolling behavior (it should know where it is

@Lazy-poet Lazy-poet force-pushed the issue/592 branch 3 times, most recently from 5b2798b to 6debd01 Compare November 7, 2022 01:39
@Lazy-poet
Copy link
Collaborator Author

Three additional things:

  • it doesn't "know" where it is. If I scroll down to the 10th one, then hit next, it takes me to the 2nd rather than the 11th.
  • The "previous" should not be shown if we are at the top of the page. The "next" should not be shown if we've passed the last one. (i.e. not shown - and the | not shown either - rather than simply disabling).
  • I think we want a bit more vertical space here too. It looks imbalanced compared to what's happening at Download section of the sidebar. Screenshot 2022-07-31 at 22 50 47
  • Automated test of the transition - when do we have the full index, and when do we show previous/next buttons.
  • Automated test of the scrolling behavior (it should know where it is

@yannickwurm My most recent commit fixes 1-3 of this comment. Tests for these behaviors are underway and will be updated soonest.

@Lazy-poet Lazy-poet force-pushed the issue/592 branch 6 times, most recently from 296d4ae to b60e9e0 Compare November 19, 2022 22:51
@yannickwurm yannickwurm requested a review from augeas July 19, 2023 12:56
@ghost
Copy link

ghost commented Jul 22, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Lazy-poet Lazy-poet closed this Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@augeas augeas Awaiting requested review from augeas

Assignees

@Lazy-poet Lazy-poet

Labels
refinement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When more than 8? queries, should show a "next query" button
2 participants
@Lazy-poet @yannickwurm