Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch thumbnail for CP #15

Open
pl-mnm opened this issue Jul 11, 2019 · 8 comments
Open

Fetch thumbnail for CP #15

pl-mnm opened this issue Jul 11, 2019 · 8 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@pl-mnm
Copy link

pl-mnm commented Jul 11, 2019

Hi, is there a solution to have the embedded media's thumbnail or image available when choosing columns in the CP's "Customize sources" table? Thx in advance.

@reganlawton
Copy link
Member

reganlawton commented Jul 11, 2019

Sorry are you about to clarify this request? I’m not quite following what your wanting.

@pl-mnm
Copy link
Author

pl-mnm commented Jul 12, 2019

Sorry about that, I haven't found the exact terms to describe this CP functionality.

In the CP entries section, when you click the little cog in the bottom left corner you can choose the fields that will be visible to the editor:

Screenshot_2019-07-12 Entries

Ideally I'd like to choose oembed's thumbnail value to show in the entries list, the same way you can add an image asset's thumbnail. Does that make sense?

@reganlawton
Copy link
Member

OH!!! You want to see the thumbnail in the element index 🤔This should be doable jsut abit fiddly and I'll have to look at maybe using transforms if the images are too large.

This is totally something I can add, so leave this with me and if I get side tracked please do ping me. I'm just a bit busy with the tail end of a few projects.

@reganlawton reganlawton self-assigned this Jul 12, 2019
@reganlawton reganlawton added the enhancement New feature or request label Jul 12, 2019
@pl-mnm
Copy link
Author

pl-mnm commented Jul 12, 2019

Thanks @reganlawton . "Element index": these are the words I was looking for!

@reganlawton
Copy link
Member

This is still on my todo list 👍

@reganlawton reganlawton added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 15, 2019
This was referenced Oct 9, 2019
@pl-mnm
Copy link
Author

pl-mnm commented Feb 3, 2020

Hi there, I'm starting a project where I could use this functionality. Is it still on the todo list? Thanks!

@reganlawton
Copy link
Member

@pl-mnm Yes it is theres a PR (#22) then I just need to review and update now that I've got a heap of other changes out. It's needs a couple of tweaks then it'll be out hoping next day or so.

@reganlawton reganlawton linked a pull request May 13, 2020 that will close this issue
@lenvanessen
Copy link

Keep in mind that you'd want to cache the thumbnails, or not do it all. We had issues with embedded assets firing hundreds of requests to get meta information from the admin, breaking the cms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants