Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site owners should be able to edit credits #211

Open
benoitchantre opened this issue Nov 27, 2018 · 3 comments
Open

Site owners should be able to edit credits #211

benoitchantre opened this issue Nov 27, 2018 · 3 comments
Labels
enhancement New feature or request Hacktoberfest

Comments

@benoitchantre
Copy link
Contributor

benoitchantre commented Nov 27, 2018

Issue Overview

Credits are now hardcoded in footer.php which make it hard for site owners to change it. I think credits should be easily editable by the admin.

Possible Solution

This can be done by adding a setting in the customizer. A text field should be enough. For WordPress.com users, there's a Footer Credit control in the Site identity section. This is a good location, but normally themes should keep their options in a Theme Options section. I think we shoud put it in Theme Options section.

In Atomic Blocks theme, the control is called Footer Tagline

footer-tagline

Pull request coming soon. Waiting for feedbacks first.

--

Edit: I see now there's a ticket in trac about that. I will try to submit a patch for core.

@benoitchantre
Copy link
Contributor Author

Any opinon on this @mor10?

@mor10 mor10 added this to the Future Release milestone Dec 20, 2018
@mor10 mor10 added the enhancement New feature or request label Dec 20, 2018
@mor10
Copy link
Contributor

mor10 commented Dec 20, 2018

Good idea. Marking it for future release.

@robruiz robruiz removed this from the Future Release milestone Oct 1, 2021
@robruiz robruiz pinned this issue Oct 1, 2021
@robruiz
Copy link
Contributor

robruiz commented Oct 1, 2021

Now that we have the EZ Customizer Component in, we should just make this a default in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants