Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement bottom-fixed/below-the-fold footer #110

Open
paaljoachim opened this issue Sep 29, 2019 · 6 comments
Open

Implement bottom-fixed/below-the-fold footer #110

paaljoachim opened this issue Sep 29, 2019 · 6 comments
Labels
enhancement New feature or request feature

Comments

@paaljoachim
Copy link

paaljoachim commented Sep 29, 2019

I adjusted these things for the Footer

Screen Shot 2019-09-29 at 22 59 54

and noticed this high footer area:

Screen Shot 2019-09-29 at 22 59 27

See also the Scroll to top button in the right corner.

Screen Shot 2019-09-29 at 23 04 09

Hmm there seems to be more then one gremlin in the system...

@aristath
Copy link
Contributor

aristath commented Oct 6, 2019

I can't replicate this one...
If you want to adjust the overall height of the footer, it should be done in the main grid instead of inside the footer grid.
I don't understand what goes on in that screenshot... Did the page perhaps have too little content, and therefore the overall site-height was smaller, resulting in the above result?

@paaljoachim
Copy link
Author

paaljoachim commented Oct 6, 2019

Let's just skip this one for now. I will close it and if needed reopen and comment on it again at a later time.

@paaljoachim
Copy link
Author

Just checked yeah. It has to do with too little content on the page.

@aristath
Copy link
Contributor

aristath commented Oct 6, 2019

OK. That makes sense then...
Will be fixed in a future version with a bottom-fixed/below-the-fold implementation I'm working on for footers.

@paaljoachim
Copy link
Author

That sounds great!

@aristath
Copy link
Contributor

aristath commented Oct 6, 2019

Reopening and marking as a future request - just to keep this as a reference.

@aristath aristath reopened this Oct 6, 2019
@aristath aristath added enhancement New feature or request feature labels Oct 6, 2019
@aristath aristath changed the title Very high footer area. Implement bottom-fixed/below-the-fold footer Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature
Projects
None yet
Development

No branches or pull requests

2 participants