Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffering still doesn't solve the problems. #136

Open
sanzeeb3 opened this issue Jun 12, 2020 · 2 comments
Open

Buffering still doesn't solve the problems. #136

sanzeeb3 opened this issue Jun 12, 2020 · 2 comments
Labels

Comments

@sanzeeb3
Copy link

https://github.com/bueltge/adminimize/blob/63750d770c1ec0af7df2de3832cdd2498d8f6ad6/inc-setup/helping_hands.php#L100

The context is 'Active Debug Helper' when enabled is creating issues with exports. For example WPForms JSON export, CSV export, etc.

Here is the example of export code: https://plugins.trac.wordpress.org/browser/wpforms-lite/trunk/includes/admin/class-tools.php#L786

Version Information

  • WordPress: 5.4.0
  • Multisite: false
  • Adminimize: 1.11.6

Steps to Reproduce

  1. Activate Adminimize plugin and enable 'Active Debug Helper' option.
  2. Activate WPForms.
  3. Export form from WPForms > Tools > Export > Form Export
  4. See the exported JSON file which results in invalid JSON File including:
    <script>console.info("Adminimize, WordPress Menu:");console.log({"2":["Dashboard","read","index.php","","menu-top menu-top-first menu-icon
@bueltge
Copy link
Collaborator

bueltge commented Jun 12, 2020

That's right. You should deactivate the debug helper, there is only for debugging and write data inside the console of the browser via JavaScript.

@bueltge
Copy link
Collaborator

bueltge commented Jun 15, 2020

But maybe we can reduce this debug script only for front-end, like is NOT Admin, Not DOING_AJAX and so on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants