Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade webonyx/graphql-php to 15.x #3077

Open
trwill opened this issue Mar 25, 2024 · 2 comments
Open

Upgrade webonyx/graphql-php to 15.x #3077

trwill opened this issue Mar 25, 2024 · 2 comments
Labels
Compat: Breaking Change This is a breaking change to existing functionality scope: dependencies Affects project dependencies such as Composer/NPM packages Type: Enhancement New feature or request

Comments

@trwill
Copy link

trwill commented Mar 25, 2024

What problem does this address?

There have been many updates to the webonyx/graphql-php package since the pinned version 14.11.10 in composer.json and it seems most fixes are not being backported.

We are running into the following issue, which was resolved some time ago, but never got ported to 14.x: webonyx/graphql-php#789

What is your proposed solution?

Upgrade to 15.x

What alternatives have you considered?

Porting to 14.x
Patching manually for our project :(

Additional Context

No response

@justlevine
Copy link
Collaborator

Thanks for opening up this issue, @trwill !

This has been discussed in the background of several other issues (e.g. #2784 #3050 ), but it's good to have a specific issue to track.

Currently implementing this is blocked by the required PHP version bump, but we've been working to clear out the existing tech debt and plan out a v2.0 roadmap, where this package bump will be included.

In the interim, there is probably a way for us to allow query || queryId to pass validation in the interim.

@justlevine justlevine added Type: Enhancement New feature or request Compat: Breaking Change This is a breaking change to existing functionality scope: dependencies Affects project dependencies such as Composer/NPM packages labels Mar 26, 2024
@jasonbahl
Copy link
Collaborator

jasonbahl commented Mar 26, 2024

I would love to start heading in this direction as long-awaited features such as the @oneOf directive will likely require us to update to newer versions of graphql-php, and in general I'd like to be in sync with the greater GraphQL / GraphQL-PHP ecosystem.

Re: php version bump, opt-in telemetry for WPGraphQL currently (as of March 26, 2024) shows the following PHP versions in use:

  • 7.1: 0%
  • 7.2: 2%
  • 7.3: 4%
  • 7.4: 48%
  • 8.0: 8%
  • 8.1: 18%
  • 8.2: 9%

This makes me feel fairly confident that with a little bit of advance warning (via a GraphQL Admin Notice, spreading awareness in Slack, Twitter, Email, etc) we would be able to update to a GraphQL-PHP version that requires 7.4 without much pushback / pain.

Upgrading to a GraphQL-PHP version that requires anything newer than 7.4 will take a bit more effort to get the community updating their servers. We should consider formalizing a plan / timeline and communicating this with the wider community so they know what to expect over the coming months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat: Breaking Change This is a breaking change to existing functionality scope: dependencies Affects project dependencies such as Composer/NPM packages Type: Enhancement New feature or request
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

3 participants