Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass NODE_ENV environment variable in to webpack #167

Open
fallenoak opened this issue Aug 12, 2016 · 0 comments
Open

Pass NODE_ENV environment variable in to webpack #167

fallenoak opened this issue Aug 12, 2016 · 0 comments

Comments

@fallenoak
Copy link
Member

Certain modules we rely on, such as React, have checks for NODE_ENV to change behavior between development and production environments. In practice, when React is in development mode, it tends to perform quite a bit worse than when it runs in production mode.

We should add logic to copy the shell env var NODE_ENV in to webpack, and ensure that when npm run web-release is called, NODE_ENV is set to production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant