Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WMO doodad sets use wrong index when loading #152

Open
fallenoak opened this issue Jun 8, 2016 · 2 comments
Open

WMO doodad sets use wrong index when loading #152

fallenoak opened this issue Jun 8, 2016 · 2 comments
Labels

Comments

@fallenoak
Copy link
Member

fallenoak commented Jun 8, 2016

Turns out MODR indices should be taken against MODD, and not against MODD-intersected-by-MODS.

We should adjust doodad loading in WMOHandler to subtract MODS.start from doodadIndex prior to pulling the entry out of the filtered doodad set.

@timkurvers
Copy link
Member

I'm assuming the current implementation should result in some funky stuff by loading the wrong doodads? Do we have any examples? Would love to see that 😄

@fallenoak
Copy link
Member Author

It's less that wrong doodads are loaded (although I'm sure if we looked closely, we'd see some wrong doodads), and more that doodads wind up associated with wrong WMO groups. I figured out this was happening when I implemented portal culling -> doodad visibility and wound up with very weird doodads disappearing or reappearing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants