Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libraries to call init and specifiy dependency versions #738

Open
sonnyp opened this issue Oct 30, 2023 · 5 comments
Open

Update libraries to call init and specifiy dependency versions #738

sonnyp opened this issue Oct 30, 2023 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@sonnyp
Copy link
Contributor

sonnyp commented Oct 30, 2023

See #736 (comment)

Let's discuss what's best first

@sonnyp
Copy link
Contributor Author

sonnyp commented Nov 3, 2023

One thing worth mentioning is that demos should sort of survive a sdk/platform bump because users can save them on their disk.

Maybe we specify all dependency versions in imports?

@theCapypara
Copy link
Contributor

Some thoughts of mine:
#732 (comment)

[...] it's only required for libraries that have more than one version (Gtk, GtkSource, etc.) and it's recommended for Adw.

It's also not needed for direct dependencies of Gtk, such as Gdk.
You can take Workbench itself as a reference for what needs versions: https://github.com/sonnyp/Workbench/blob/main/src/init.js#L1-L7

An additional thing:
We should find out if Pango 1 is an implicit dependency of GTK, otherwise the release of Pango 2 could break things and we should also add Pango to the list.

@theCapypara
Copy link
Contributor

workbenchdev/demos#25 would also help here with identifying breaking changes when Sdk version is bumped. workbenchdev/demos#24 even more so.

@UrtsiSantsi
Copy link
Contributor

I think pango 1 is dependency for gtk 4 and pango 2 is gtk 5 material, but I'm not 100% sure.

@sonnyp
Copy link
Contributor Author

sonnyp commented Feb 11, 2024

Related #879

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants