Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UNKNOWN value on unset User-Agent header #17

Open
elpiel opened this issue Nov 23, 2020 · 0 comments
Open

UNKNOWN value on unset User-Agent header #17

elpiel opened this issue Nov 23, 2020 · 0 comments

Comments

@elpiel
Copy link

elpiel commented Nov 23, 2020

When parsing a request without an User-Agent, woothee returns UNKNOWN (string), however for a cleaner API I would suggest to have some sort of an enum or just an Option if the parser couldn't determine the given part.

This way a user of the crate (me) wouldn't need to filter the UNKNOWN string in order to get an Option that will show whether there is a value parsed.

Update: I saw that the rest of the woothee libraries do the same and I understand this might be to have consistency across them, however I still want to see your thoughts about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant