Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci-jobs is not returning tests for some dependencies changes #47347

Open
adimoldovan opened this issue May 10, 2024 · 0 comments
Open

ci-jobs is not returning tests for some dependencies changes #47347

adimoldovan opened this issue May 10, 2024 · 0 comments
Labels
focus: monorepo infrastructure Issues and PRs related to monorepo tooling. focus: testing workflows Issues related to test related workflows (daily, release, merge to trunk etc). priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. team: Vortex WooCommerce monorepo tools and test suite.

Comments

@adimoldovan
Copy link
Contributor

ci-jobs utility should return tests jobs for core when only dependencies of any level are changed.
This doesn't happen with @woocommerce/components, which is a dependency of admin-library, which is a dependency of woocommerce plugin. The expectation is that a change in @woocommerce/components would trigger woocommerce plugin's tests.

Note: it works as expected with other dependencies, like @woocommerce/product-editor.
@adimoldovan adimoldovan added priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. focus: monorepo infrastructure Issues and PRs related to monorepo tooling. focus: testing workflows Issues related to test related workflows (daily, release, merge to trunk etc). team: Vortex WooCommerce monorepo tools and test suite. labels May 10, 2024
@adimoldovan adimoldovan changed the title ci-jobs is not returning tests when some dependencies are changed. ci-jobs is not returning tests for some dependencies changes May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
focus: monorepo infrastructure Issues and PRs related to monorepo tooling. focus: testing workflows Issues related to test related workflows (daily, release, merge to trunk etc). priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. team: Vortex WooCommerce monorepo tools and test suite.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adimoldovan