Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade SwiftLint to 0.41.0 to use only_rules Instead of whitelist_rules #3173

Open
shiki opened this issue Nov 19, 2020 · 4 comments · May be fixed by #6956
Open

Upgrade SwiftLint to 0.41.0 to use only_rules Instead of whitelist_rules #3173

shiki opened this issue Nov 19, 2020 · 4 comments · May be fixed by #6956
Labels
category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. type: task An internally driven task.
Projects
Continuous Improvements

Comments

@shiki
Copy link
Member

shiki commented Nov 19, 2020 •
edited

This is probably the last item we need to remove non-inclusive languages from the project.

SwiftLint version 0.41.0 adds an inclusive version for this, only_rules (realm/SwiftLint#3243). At the time of this writing, Hound only supports 0.27.0.

I submitted a request to Hound here: houndci/hound#1825.

My initial attempt for this is here: #3172.
@shiki shiki added status: blocked Blocked from progressing somehow, waiting for another piece of work to be done. category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. labels Nov 19, 2020
@shiki shiki added this to Needs Triage in Continuous Improvements via automation Nov 19, 2020
@shiki shiki moved this from Needs Triage to Waiting in Continuous Improvements Nov 19, 2020
@shiki shiki changed the title Upgrade SwiftLint to 0.41.0 To Use only_rules instead of whitelist_rules Upgrade SwiftLint to 0.41.0 To Use only_rules Instead Of whitelist_rules Nov 19, 2020
@shiki shiki changed the title Upgrade SwiftLint to 0.41.0 To Use only_rules Instead Of whitelist_rules Upgrade SwiftLint to 0.41.0 to use only_rules Instead of whitelist_rules Nov 19, 2020
@shiki shiki mentioned this issue Nov 19, 2020
Closed
1 task
@shiki shiki added the type: task An internally driven task. label Feb 25, 2021
@joshheald
Copy link
Contributor

Hound now supports SwiftLint 0.43.1.

@shiki Should this now be unblocked and moved to prioritised?

@shiki
Copy link
Member Author

shiki commented May 26, 2022

Looks like it! Thanks for checking.

Odd that they didn't close houndci/hound#1825. 🤔

@shiki shiki removed the status: blocked Blocked from progressing somehow, waiting for another piece of work to be done. label May 26, 2022
@peril-woocommerce
Copy link

Fails
🚫 Please add a feature label to this issue. e.g. 'feature: stats'

Generated by 🚫 dangerJS

@joshheald joshheald linked a pull request May 26, 2022 that will close this issue
Draft
1 task
@joshheald
Copy link
Contributor

It seems like that support isn't all the way there yet... I've added a comment to houndci/hound#1825

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. type: task An internally driven task.
Projects
No open projects
Continuous Improvements
  
Waiting
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade Swiftlint to 0.41.0 woocommerce/woocommerce-ios
2 participants
@shiki @joshheald