Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When checking for saved cards settings, take into account card ordering also #12743

Closed
Tracked by #12655
hafizrahman opened this issue May 15, 2024 · 1 comment · Fixed by #12811
Closed
Tracked by #12655

When checking for saved cards settings, take into account card ordering also #12743

hafizrahman opened this issue May 15, 2024 · 1 comment · Fixed by #12811
Assignees

Comments

@hafizrahman
Copy link
Contributor

hafizrahman commented May 15, 2024

To replicate issue:

  1. start app
  2. Edit dashboar, then enable and put an m2 card at the top (e.g: inbox or review), save
  3. restart app
  4. notice that the m2 card from point 2 is enabled but shown at the bottom, after the m1 cards.

Expected:
the m2 card should stay where it was before restarting.

The fix should be added in updateDashboardCards() in DashboardViewModel

@dangermattic
Copy link
Collaborator

🚫 Please add a type label (e.g. type: enhancement) and a feature label (e.g. feature: stats) to this issue.

@hafizrahman hafizrahman self-assigned this May 22, 2024
@hafizrahman hafizrahman changed the title When checking for saved cards, take into account saved card ordering also When checking for saved cards settings, take into account card ordering also May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants