Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS] UI: CurrencyFormatter usage #12705

Closed
iamgabrielma opened this issue May 13, 2024 · 3 comments
Closed

[Woo POS] UI: CurrencyFormatter usage #12705

iamgabrielma opened this issue May 13, 2024 · 3 comments
Assignees
Labels
feature: POS type: task An internally driven task.

Comments

@iamgabrielma
Copy link
Contributor

UI-wise, we can start applying the different currencies via the existing CurrencyFormatter. While most of it is already in WooFoundation, there's some code and dependencies scattered through different frameworks. At the moment:

  • WooFoundation: CurrencyFormatter
  • WooFoundation: CurrencySettings
  • WooFoundation: CurrencyCode
  • WooFoundation: CurrencyPosition
  • Yosemite: Order+CurrencyFormattedValues
  • WooCommerce: CurrencyFormatterTests

Regarding tests, should we duplicate those in the POS framework as well? I'm not quite sure the WooFoundation framework needs its own testing target for the moment but if we end splitting the pos then it could be the case.

@iamgabrielma iamgabrielma added type: task An internally driven task. feature: POS labels May 13, 2024
@dangermattic
Copy link
Collaborator

Thanks for reporting! 👍

@jaclync
Copy link
Contributor

jaclync commented May 13, 2024

This task seems to be affected by the uncertainty of keeping POS in a framework pfoUAQ-EF-p2#comment-517.

@iamgabrielma
Copy link
Contributor Author

Closed via #12819

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: POS type: task An internally driven task.
Projects
None yet
Development

No branches or pull requests

4 participants