Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Woo POS] UI/Navigation: Root navigation, exit POS mode, and handle app's main tab visibility #12704

Open
iamgabrielma opened this issue May 13, 2024 · 3 comments
Labels
feature: POS type: task An internally driven task.

Comments

@iamgabrielma
Copy link
Contributor

iamgabrielma commented May 13, 2024

The experimental entry point for POS currently works as a full-screen modal overlay, if we remove the modal behaviour, we inherit the app's top and bottom navigation.

A minimal navigation should tackle:

  • POS dashboard shouldn't be a full-screen modal overlay (perhaps?)
  • Add an exit POS button and behaviour
  • Toggle bottom app's bar visibility (my home, orders, products, menu) on enter/exit POS mode.
  • A root navigation stack or path for all subviews and navigation states

Additionally, from a review on a different issue:

it's tricky in push navigation when we can't easily hide the tab bar like in UIKit (the design prototype seems to use modal presentation for now but we can update it later). The only other potential workaround I found is this SO answer, but I haven't tried it and we can revisit the workarounds when we're more sure about the UX.

@iamgabrielma iamgabrielma added type: task An internally driven task. feature: POS labels May 13, 2024
@dangermattic
Copy link
Collaborator

Thanks for reporting! 👍

@iamgabrielma iamgabrielma changed the title [Woo POS] UI - Navigation: Exit POS & handle app's main tab navigation [Woo POS] UI/Navigation: Exit POS & handle app's main tab navigation May 13, 2024
@jaclync
Copy link
Contributor

jaclync commented May 13, 2024

POS dashboard shouldn't be a full-screen modal overlay

Does this mean that the POS dashboard should be presented in pushed navigation instead of a modal, while still being fullscreen? At first I thought we didn't want this view to be fullscreen, so just clarifying.


Also it looks like it's implemented in #12700?

@iamgabrielma
Copy link
Contributor Author

iamgabrielma commented May 13, 2024

Does this mean that the POS dashboard should be presented in pushed navigation instead of a modal, while still being fullscreen? At first I thought we didn't want this view to be fullscreen, so just clarifying.

That's my understanding: The POS dashboard should have no reference to the WooCommerce app navigation, the only connection through navigation should be the entry point and the "Exit POS" button, and should be full-screen from what I see on the wireframes (so no common top or bottom navigation).

Also it looks like it's implemented in #12700?

Yeah, I'm not sure if there are better solutions of what I propose on that PR. Ideally after that we could use a NavigationPath since has type-erasure and we only need the destination views to be hashable for it to work, or a NavigationStack

@iamgabrielma iamgabrielma changed the title [Woo POS] UI/Navigation: Exit POS & handle app's main tab navigation [Woo POS] UI/Navigation: Root navigation, exit POS mode, and handle app's main tab visibility May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: POS type: task An internally driven task.
Projects
None yet
Development

No branches or pull requests

3 participants