Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for menu description. #1595

Open
grig-23 opened this issue Jan 25, 2021 · 1 comment · Fixed by #1771 · May be fixed by #1943
Open

Support for menu description. #1595

grig-23 opened this issue Jan 25, 2021 · 1 comment · Fixed by #1771 · May be fixed by #1943
Labels
type: compatibility

Comments

@grig-23
Copy link

grig-23 commented Jan 25, 2021

Is your feature request related to a problem? Please describe.

Currently, Storefront theme does not support menu descriptions.

Describe the solution you'd like

Add the support for menu descriptions.

Additional context

  1. Head to wp-admin >> Appearance >> Menus
  2. In the "Screen options" at the top, tick the "descriptions" checkbox.
  3. Add descriptions to some menu items. That won't work.

Screenshot
Screenshot direct link: https://d.pr/i/oROi8H

Reported in 26823683-hc
@nielslange nielslange mentioned this issue Aug 26, 2021
Merged
@nielslange nielslange linked a pull request Apr 4, 2022 that will close this issue
Open
@gigitux gigitux mentioned this issue Apr 4, 2022
Merged
@gigitux
Copy link
Contributor

gigitux commented Apr 4, 2022

We decided to revert #1711 because we noticed that:

  • on the secondary menu, the menu, and the sub-menu are bottom aligned instead of top-aligned. Fixed with Add support for sub menu description #1943
  • on the mobile, the menu doesn’t look very well (“description” should be gray and there is too much margin).

image

@gigitux gigitux reopened this Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: compatibility
Projects
None yet
Milestone
No milestone
3 participants
@gigitux @grig-23 @budzanowski