Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the migration restart on plugin deactivation #990

Open
rrennick opened this issue Sep 19, 2023 · 0 comments
Open

Update the migration restart on plugin deactivation #990

rrennick opened this issue Sep 19, 2023 · 0 comments
Labels
priority: normal The issue/PR is normal priority—not many people are affected or there’s a workaround, etc. type: enhancement The issue is a request for an enhancement.

Comments

@rrennick
Copy link
Collaborator

In #470 we added a safety fallback for sites that may have had a plugin which includes pre-3.0 action scheduler. While this is still possible the number of sites would be very small. AS is recreating the migration action every time a plugin is deactivated.

There are also edge cases where the site has difficulty in marking the migration as complete (eg. #979) and the action ends up creating a large number of failed actions which do not get purged.

We should add some logic to this to eliminate creating the action when it is unnecessary. An example would be check the registered versions to see if any pre-3.0.

@rrennick rrennick added the type: enhancement The issue is a request for an enhancement. label Sep 19, 2023
@lsinger lsinger added the priority: normal The issue/PR is normal priority—not many people are affected or there’s a workaround, etc. label Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal The issue/PR is normal priority—not many people are affected or there’s a workaround, etc. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants