Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of calendar "view only" mode #876

Closed
1 task done
felixmosh opened this issue Jun 25, 2023 · 5 comments · May be fixed by #898
Closed
1 task done

Add support of calendar "view only" mode #876

felixmosh opened this issue Jun 25, 2023 · 5 comments · May be fixed by #898
Labels
enhancement New feature or request stale

Comments

@felixmosh
Copy link

Before you start - checklist

  • I have checked if this feature request is not already reported

Description

In my app there is a requirement to show a simple calendar with holidays, without the need to select days etc..., in this case there is no reason to render the Tile as button (interactive element) but it can be a simple div.

Proposed solution

I've patched the lib, and rendered a div if onClick is not defined.

Alternatives

No response

Additional information

No response
@felixmosh felixmosh added the enhancement New feature or request label Jun 25, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this issue will be closed in 14 days.

@github-actions github-actions bot added the stale label Sep 25, 2023
@felixmosh
Copy link
Author

Ping

wojtekmaj added a commit that referenced this issue Sep 25, 2023
@wojtekmaj
Add support for tileAs prop
dbb3342 
Closes #876
@wojtekmaj wojtekmaj mentioned this issue Sep 25, 2023
Draft
@wojtekmaj
Copy link
Owner

Tried to do that but the types in Calendar.tsx get too complex for me to handle it quicky. You're welcome to have a look if you'd like to get it done asap.

@wojtekmaj wojtekmaj removed the stale label Sep 25, 2023
@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this issue will be closed in 14 days.

@github-actions github-actions bot added the stale label Dec 25, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

This issue was closed because it has been stalled for 14 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for tileAs prop wojtekmaj/react-calendar
2 participants
@wojtekmaj @felixmosh