Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown select for month and year #266

Open
kennyjwilli opened this issue Oct 30, 2019 · 6 comments
Open

Dropdown select for month and year #266

kennyjwilli opened this issue Oct 30, 2019 · 6 comments
Assignees
Labels
enhancement New feature or request fresh

Comments

@kennyjwilli
Copy link

Is it possible to change the way you navigate from month to month & year to year to simply be a dropdown? I find the entire calendar switching views jarring. I'd like to have it so when you click on the year, it will simply show a dropdown of years to select. When you click on the month, it shows a dropdown of the months.

@wojtekmaj
Copy link
Owner

Hi,
that is quite a complicated problem. In current React-Calendar architecture, calendar layout tied closely with its logic in root component. I think it would make sense to split the view from the logic, essentially making it possible to replace the whole view logic - but that would mean you would need to handle displaying months, years, decades etc. on your own, too. This would be helpful for testability, though!

Other way is to just create renderNavigation prop and allow people to redefine the logic of rendering navigation, and making sure that existing elements are exported for reuse.

What do you think?

@wojtekmaj wojtekmaj added the enhancement New feature or request label Nov 10, 2019
@wojtekmaj wojtekmaj self-assigned this Nov 10, 2019
@wojtekmaj
Copy link
Owner

Kinda related to #193

@kennyjwilli
Copy link
Author

Splitting the view from the logic makes sense.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this issue will be closed in 14 days.

@github-actions github-actions bot added the stale label Dec 6, 2021
@kennyjwilli
Copy link
Author

Still interested in this.

@github-actions github-actions bot removed the stale label Dec 13, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this issue will be closed in 14 days.

@github-actions github-actions bot added the stale label Mar 14, 2022
@wojtekmaj wojtekmaj added fresh and removed stale labels Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fresh
Projects
None yet
Development

No branches or pull requests

2 participants