New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A couple bugs with getModel() method #73

Open

jacobg opened this issue Jan 22, 2015 · 0 comments

jacobg commented Jan 22, 2015

In getModel() method:

The call to Ext.ModelManager.get should be Ext.ModelManager.getModel.
It defines SlideNavigationPanelItem model class as a global variable via Ext.define. That is bad practice to pollute the global namespace. A better way to set the model name would be like this:

var className = this.self.getName(),
    model = className.substr(0, className.lastIndexOf('.')) + '.SlideNavigationPanelItem';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment