Skip to content
This repository has been archived by the owner on Jan 26, 2019. It is now read-only.

Unit tests are failing when using dynamic imports #359

Open
rolandjitsu opened this issue Jul 8, 2018 · 2 comments · May be fixed by #399
Open

Unit tests are failing when using dynamic imports #359

rolandjitsu opened this issue Jul 8, 2018 · 2 comments · May be fixed by #399

Comments

@rolandjitsu
Copy link

Is this a bug report?

Yes.

Can you also reproduce the problem with npm 4.x?

Yes.

Which terms did you search for in User Guide?

Unexpected token, Unexpected token import, dynamic import

Environment

  1. npm ls react-scripts-ts (if you haven’t ejected): 2.16.0
  2. node -v: 8.11.2
  3. npm -v: 5.6.0
  4. yarn --version (if you use Yarn): 1.7.0
  5. npm ls react-scripts-ts (if you haven’t ejected):

Then, specify:

  1. Operating system: macOS Sierra
  2. Browser and version (if relevant): Chrome

Steps to Reproduce

Go to cra-workspaces#dynamic-import:

  1. Clone repo
  2. Run yarn install from root
  3. Run yarn test

NOTE: Use yarn start to run the app and confirm it actually works.

Expected Behavior

Tests would pass without errors.

Actual Behavior

Tests are failing with:

/Users/rolandjitsu/Projects/cra-workspaces/apps/cra/src/app.tsx: Unexpected token (5:33)
        3 | import Loadable from 'react-loadable';
        4 | var DynamicComponent = Loadable({
      > 5 |     loader: function () { return import('./dynamic'); },
          |                                  ^
        6 |     loading: function () { return React.createElement("span", null, "Loading ..."); }
        7 | });
        8 | var App = /** @class */ (function (_super) {

Reproducible Demo

See cra-workspaces#dynamic-import and use instructions above to reproduce.

@ianschmitz
Copy link
Contributor

Try disabling allowSyntheticDefaultImports in your tsconfig.json if you have it enabled

@topaxi
Copy link

topaxi commented Aug 29, 2018

This was fixed in ts-jest kulshekhar/ts-jest#258 (comment).
I tried to get it upgraded locally in react-scripts-ts but failed, maybe I'm missing something as I'm pretty new to the whole ecosystem.

@fozzleberry fozzleberry linked a pull request Sep 15, 2018 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants