Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containerize / Dockerize csvkit #1240

Open
wesley-dean-flexion opened this issue Apr 22, 2024 · 6 comments
Open

Containerize / Dockerize csvkit #1240

wesley-dean-flexion opened this issue Apr 22, 2024 · 6 comments
Labels

Comments

@wesley-dean-flexion
Copy link

In #1239 I mentioned my work with MegaLinter. MegaLinter, in addition to supporting installs via npm, pip, etc., can also work with container images. A quick search on DockerHub seems to indicate that some folks have rolled their own csvkit images but it doesn't look like anything's being automatically generated. For example, I see that v1.5.0 is the most recent release (March 28, 2024) while the most recent image (on the first page of results on) DockerHub appears to be May 2nd, 2023 (almost a year ago).

So, babbling on, I've a workflow that I use to build and push images to GHCR, DockerHub, and Quay (all are optional) for several architectures (AMD64, ARM64, etc.):

https://github.com/wesley-dean-flexion/upload-sarif-to-defectdojo/blob/main/.github/workflows/publish.yml

The workflow is triggered by commits to main (configurable) updating the :edge tag of the images and GitHub releases triggering updates to :latest, versioned tags (e.g., v1, v1.5, and v1.5.0 in this case), etc..

If it would be helpful, I would be happy to submit a PR with it setup along with a Dockerfile to streamline the image build process.

If this isn't something that's interesting to you, that's totally cool. I don't want to make any more work for you than you've already got.

Thanks again!

@jpmckinney
Copy link
Member

Could you start with authoring the Dockerfile?

My workflow would tend to be much simpler e.g. adding a condition to only run on tags to this workflow: https://ocp-software-handbook.readthedocs.io/en/latest/docker/build.html

@wesley-dean-flexion
Copy link
Author

I would be happy to do so. I'll have a PR for you fairly shortly.

@wesley-dean-flexion
Copy link
Author

I've a Dockerfile builds an image that clocks in at 135MB with the v2.0.0 release. I just need to fork and create a PR.

@wesley-dean-flexion
Copy link
Author

I'll be adding another PR to incorporate publishing the images in the next few days.

@wesley-dean-flexion
Copy link
Author

@jpmckinney I added #1245 as a draft PR as #1240 needs to be merged first (#1245 includes a Dockerfile that's defined in #1240). I'm happy to walk through the PR and the configuration mentioned there if that's helpful.

No rush. Never a rush.

@jpmckinney
Copy link
Member

Thank you! I'll take a look through once I have a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants