Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formats missing in esbuild bundle output #119

Open
cprass opened this issue Jun 14, 2021 · 1 comment
Open

Formats missing in esbuild bundle output #119

cprass opened this issue Jun 14, 2021 · 1 comment

Comments

@cprass
Copy link

cprass commented Jun 14, 2021

When bundling winston with esbuild, the format exports are missing because they are required dynamically. Esbuild currently can't handle dynamic import resolution.

evanw/esbuild#56 explains why esbuild can't handle the dynamic imports, there seems to be a plugin on the way tho (evanw/esbuild#700).

I guess those lines are the main issue: https://github.com/winstonjs/logform/blob/b91bfa5c32a6077adcf2526ee8d3414c7171e557/index.js#L24#L32

Maybe related to #5

@empperi
Copy link

empperi commented Aug 25, 2021

There is already a PR for this open, it just needs merging #117

I'm personally waiting on this PR before I can continue with my personal project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants