Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit example-x-image-bg from dist #152

Open
WGroenestein opened this issue Nov 19, 2016 · 1 comment
Open

Omit example-x-image-bg from dist #152

WGroenestein opened this issue Nov 19, 2016 · 1 comment

Comments

@WGroenestein
Copy link
Contributor

Was playing around with webpack a bit and ran into the issue with "example_dark.jpg" and "example_light.jpg". These 2 images end up in the winstrap.css file resulting in webpack not being able to resolve them as the images are not distributed (i.e. in the "dist" folder). To me it seems like these styles are used for the docs only and don't really belong to the theme and should therefore be omitted. (If I'm wrong here, I guess the images should be distributed).

https://github.com/winjs/winstrap/blob/master/dist/css/winstrap.css#L11665

@khowling
Copy link

khowling commented May 4, 2017

hit the same issue, images folder missing from /dist. can easily copy it across, but it errors the automated build process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants