Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress Bar and Progress Ring #115

Open
mtunad opened this issue Nov 2, 2015 · 4 comments
Open

Progress Bar and Progress Ring #115

mtunad opened this issue Nov 2, 2015 · 4 comments
Labels

Comments

@mtunad
Copy link

mtunad commented Nov 2, 2015

I have two issues with progress indicators.

I like loading indicator in Windows Phone's interface. But in winstrap, there's big ugly black bar above progress bar. Yes, I can remove it with CSS tricks, but why it is there in first place? This one is much better than current implementation. Also you can't apply text-center to winstrap's progress bar.

Other thing is about progress ring. If you apply text-center with a div to progress rings, they don't move to horizontally center and they look ugly.

@joetheday joetheday added the bug label Nov 2, 2015
@joetheday
Copy link
Contributor

@entriol you are correct. .progress-bar and .progress-ring both need to be updated to the latest designs and we'll fix these bugs when we take that work. We are tracking this internally.

@mtunad
Copy link
Author

mtunad commented Nov 3, 2015

Great. I look forward to updates.

@codefactorymx
Copy link
Contributor

codefactorymx commented Feb 21, 2018

Hi,
I have fixed this issues. You can download from my repo
https://github.com/codefactorymx/winstrap/tree/master/dist/css

To center progress bar or rings, just put them inside a div and set the paretn div to text-align:center

<div style="text-align: center">code for the ring or bar</div>

@englishextra
Copy link

hi @codefactorymx why wouldnt you make it via css or is it?

mlijanto pushed a commit that referenced this issue Mar 27, 2018
#162)

* Added inline-flex for parent of search bar, fix issues in mobile

* Issue # 115 - Progress Bar and Progress Ring
Fixed the progress bar and ring issues, added the center alignment option.
Documentation was updated

* Fixed the documentation of NavBar, Hamburguer icon is not displayed.
Container is not centering the content

* Fixed the documentation of NavBar, changed the overrides to correct file.

* Removed override from incorrect file

* Recompiled optional css

* Fixed documentation of NavBar, chevron icons in blue bar.
codefactorymx added a commit to codefactorymx/winstrap that referenced this issue May 4, 2018
Fix for issues winjs#115 and winjs#159 - Navbar search box and progress ring/ba…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants