Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter confused #179

Open
tcper opened this issue Apr 29, 2022 · 2 comments
Open

Parameter confused #179

tcper opened this issue Apr 29, 2022 · 2 comments

Comments

@tcper
Copy link

tcper commented Apr 29, 2022

pts: GroupLike

Parameters like this really confused,
What is the differences of PtLikeIterable or GroupLike
Or construct a Group(new Pt(x,y), new Pt(a,b)), Group([1,2,3,4])
In practice, I think all these objects are different, because some works in Curve, some don't.

I think this is the biggest obstacle in this project, people have to read your Demo code to try which works.

@williamngan
Copy link
Owner

Thanks for the feedback @tcper -- there might be some ways to simplify. I'll look into this.

@williamngan
Copy link
Owner

Following up on this. As a starting point, I've updated the documentations so it's clearer what these types mean.

Not sure if I can simplify it further. Needed the Iterable types as we want to support non-array iterables.

When in doubt, just pass a Group instance which should work always :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants