Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a download function #165

Open
williamngan opened this issue Dec 12, 2021 · 2 comments
Open

Implement a download function #165

williamngan opened this issue Dec 12, 2021 · 2 comments
Assignees

Comments

@williamngan
Copy link
Owner

No description provided.

@williamngan williamngan self-assigned this Dec 12, 2021
williamngan added a commit that referenced this issue Mar 6, 2022
@HenrySkup
Copy link

I've done some work in trying to implement this. There are some complications due to some security issues of downloading embedded objects (I believe canvases which are in svgs may not be automatically inserted), and text/DOM and particularly <foreignObjects> elements may give issues.

see: https://observablehq.com/@mbostock/saving-svg
and : https://observablehq.com/@mootari/embed-canvas-into-svg
and : https://stackoverflow.com/questions/39148582/javascript-todataurl-throwing-security-error-tainted-canvases-may-not-be-ex/39150005

@williamngan williamngan reopened this Mar 8, 2022
@williamngan
Copy link
Owner Author

Interesting. Thanks for the great info @HenrySkup . I'm reopening this issue so that we don't lose track of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants