Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documents are old #76

Open
calio opened this issue Jun 6, 2018 · 5 comments
Open

Documents are old #76

calio opened this issue Jun 6, 2018 · 5 comments

Comments

@calio
Copy link
Contributor

calio commented Jun 6, 2018

There are some new breaking changes in the current version of raft which is very different than the one used in ticketd. For example, things like log_get_node_id changed the way how users should interact with the library.

Can you update the documents or update the raft code in ticketd?

@vgfree
Copy link

vgfree commented Jun 6, 2018

You can see new ticketd at https://github.com/vgfree/EasyRaft/tree/master/example/ticketd

@calio
Copy link
Contributor Author

calio commented Jun 6, 2018

In raft_apply_entry function there is no check to verify if me->cb.log_get_node_id is set or not. So I guess this call back is now required. I don't see log_get_node_id get set anywhere in your version of ticketd, can you verify?

@vgfree
Copy link

vgfree commented Jun 6, 2018

It's a bug. Thanks!

@q96456
Copy link

q96456 commented Jun 15, 2018

how to use log_get_node_id. I can'f find the function in https://github.com/vgfree/EasyRaft/tree/master/example/ticketd now.

@vgfree
Copy link

vgfree commented Jun 15, 2018

It's update.
like this:

int __raft_log_get_node_id(
raft_server_t *raft,
void *user_data,
raft_entry_t *entry,
raft_index_t entry_idx
)
{
entry_cfg_change_t *change = (entry_cfg_change_t *)entry->data.buf;
return change->node_id;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants