Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route /users/# shows empty books on latest books list #293

Open
FredericoAndrade opened this issue Jan 11, 2018 · 1 comment
Open

Route /users/# shows empty books on latest books list #293

FredericoAndrade opened this issue Jan 11, 2018 · 1 comment
Labels
Component: Platform Operational, app-wide or other core concerns. Help Wanted Interested in open source? These issues are good places to help.

Comments

@FredericoAndrade
Copy link
Contributor

When looking at a user's page, only books with phrases should be shown, using "most_recent_with_content" method or similar from Book model.

image

Logged in user should only be able to see books by other authors if they have phrases. This is the case both in the global list and in the local user list.
@FredericoAndrade FredericoAndrade added the Help Wanted Interested in open source? These issues are good places to help. label Jan 11, 2018
@AmrAdelKhalil
Copy link
Contributor

Hi @FredericoAndrade "most_recent_with_content" already prevents books with no phrases to be shown up in the "latest books" list even if it was the owner of the book, I tried to create a new book with no phrases and it does not appear in the list , So i'm going to add a pull request that prevents to the logged in user to see his own books in the "latest books", Could you tell me how did you get this case in the image attached to the issue, please?
https://github.com/wikitongues/poly/pull/294

@FredericoAndrade FredericoAndrade added Help Wanted Interested in open source? These issues are good places to help. Component: Platform Operational, app-wide or other core concerns. and removed Enhancement Help Wanted Interested in open source? These issues are good places to help. labels Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Platform Operational, app-wide or other core concerns. Help Wanted Interested in open source? These issues are good places to help.
Projects
None yet
Development

No branches or pull requests

2 participants