Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make debug output available with command line option #105

Open
drygdryg opened this issue Nov 18, 2020 · 1 comment
Open

Make debug output available with command line option #105

drygdryg opened this issue Nov 18, 2020 · 1 comment

Comments

@drygdryg
Copy link
Contributor

It would be convenient to analyze the vulnerability of routers if debug output (DEBUG_PRINT macros) were available through the command line flag. It can be --debug or verbosity level 4 (-v 4).

@rofl0r
Copy link
Collaborator

rofl0r commented Nov 18, 2020

iirc debug on/off is a compile time option because there was concern it might make the binary slower. if you can show numbers that the speed is essentially unchanged for a binary with debug option compiled in but disabled, and one without it compiled in, then i guess nothing speaks against adding an option.
basically the code would just need to set a flag to 1 if --debug is set, and change the DEBUGPRINT macro to if(debug_flag) { .... }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants