SIGBUS in Player::rediscover_node

[bunnybot]

Mirrored from Codeberg
Created on Sat Mar 02 16:41:41 CET 2024 by Benedikt Straub (Nordfriese)

---

Describe the bug
A non-reproducible crash with a SIGBUS (7) that happens sometimes while loading a map.

To reproduce
Not reproducible.
I got this twice now, once while loading a saved game and once while loading a map in the editor.
In both cases, I was using the in-game/in-editor load function. So perhaps some data structure is not being cleaned up or not being reinitialized correctly before loading new data.

Crash log

In editor

Crash report for Widelands 1.2~git26567 (b33e4b3@master) Release at 2024-03-02T16.26.36, signal 7 (Bus error)

**** BEGIN BACKTRACE ****
./widelands(+0x2ef791)[0x563e830f8791]
/lib/x86_64-linux-gnu/libc.so.6(+0x3c510)[0x7f3a6585a510]
./widelands(_ZN9Widelands6Player15rediscover_nodeERKNS_3MapERKNS_7FCoordsE+0x41)[0x563e831c7091]
./widelands(+0x3f0239)[0x563e831f9239]
./widelands(_ZN9Widelands13BaseImmovable12set_positionERNS_14EditorGameBaseERKNS_6CoordsE+0xfb)[0x563e833b0e3b]
./widelands(_ZN9Widelands9Immovable6Loader4loadER8FileReadh+0x92)[0x563e833b28f2]
./widelands(_ZN9Widelands9Immovable4loadERNS_14EditorGameBaseERNS_15MapObjectLoaderER8FileRead+0x25b)[0x563e833b459b]
./widelands(_ZN9Widelands15MapObjectPacket4readER10FileSystemRNS_14EditorGameBaseERNS_15MapObjectLoaderE+0x22e)[0x563e834579ee]
./widelands(_ZN9Widelands18WidelandsMapLoader17load_map_completeERNS_14EditorGameBaseENS_9MapLoader8LoadTypeE+0x4d9)[0x563e831fcfc9]
./widelands(_ZN17EditorInteractive4loadERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE+0x142)[0x563e83129be2]
./widelands(_ZN15MainMenuLoadMap10clicked_okEv+0x223)[0x563e8314a203]
./widelands(+0x3c3e86)[0x563e831cce86]
./widelands(_ZN2UI5TableIPvE17handle_mousepressEhii+0xfb)[0x563e8325f82b]
./widelands(+0x44c74f)[0x563e8325574f]
./widelands(+0x44c74f)[0x563e8325574f]
./widelands(+0x44c74f)[0x563e8325574f]
./widelands(+0x44c74f)[0x563e8325574f]
./widelands(+0x44c74f)[0x563e8325574f]
./widelands(_ZN2UI5Panel13ui_mousepressEhii+0xc4)[0x563e83255914]
./widelands(_ZN13WLApplication12handle_inputEPK13InputCallback+0x3ae)[0x563e830fcb0e]
./widelands(_ZN2UI5Panel13do_redraw_nowEbRKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEE+0x207)[0x563e83259097]
./widelands(_ZN2UI5Panel6do_runEv+0x6e4)[0x563e8325a594]
./widelands(_ZN17EditorInteractive13do_run_editorENS_4InitERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEES8_+0x360)[0x563e83129fa0]
./widelands(_ZN17EditorInteractive10run_editorEPN2UI5PanelENS_4InitERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEESB_+0x24)[0x563e8312a214]
./widelands(_ZN6FsMenu8MainMenu6actionENS_10MenuTargetE+0x88e)[0x563e8328419e]
./widelands(+0x47b44e)[0x563e8328444e]
./widelands(_ZN6FsMenu8MainMenu10handle_keyEb10SDL_Keysym+0x249)[0x563e832846a9]
./widelands(_ZN2UI5Panel6do_keyEb10SDL_Keysym+0xe3)[0x563e83253773]
./widelands(_ZN13WLApplication12handle_inputEPK13InputCallback+0x4c2)[0x563e830fcc22]
./widelands(_ZN2UI5Panel6do_runEv+0x690)[0x563e8325a540]
./widelands(_ZN6FsMenu8MainMenu9main_loopEv+0x1a)[0x563e8327e16a]
./widelands(_ZN13WLApplication3runEv+0x600)[0x563e83102ce0]
./widelands(main+0x89)[0x563e83040259]
/lib/x86_64-linux-gnu/libc.so.6(+0x276ca)[0x7f3a658456ca]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0x85)[0x7f3a65845785]
./widelands(_start+0x21)[0x563e830f6961]
**** END BACKTRACE ****

In-game

Crash report for Widelands 1.2~git26536 (611be08@master) Release at 2024-02-13T20.17.31, signal 7 (Bus error)

**** BEGIN BACKTRACE ****
./widelands(+0x2ee201)[0x5555e92fa201]
/lib/x86_64-linux-gnu/libc.so.6(+0x3c510)[0x7f1ff525a510]
./widelands(_ZN9Widelands6Player15rediscover_nodeERKNS_3MapERKNS_7FCoordsE+0x41)[0x5555e93c8aa1]
./widelands(+0x3eea59)[0x5555e93faa59]
./widelands(_ZN9Widelands13BaseImmovable12set_positionERNS_14EditorGameBaseERKNS_6CoordsE+0xfb)[0x5555e95b288b]
./widelands(_ZN9Widelands9Immovable6Loader4loadER8FileReadh+0x92)[0x5555e95b4202]
./widelands(_ZN9Widelands9Immovable4loadERNS_14EditorGameBaseERNS_15MapObjectLoaderER8FileRead+0x25b)[0x5555e95b5eab]
./widelands(_ZN9Widelands15MapObjectPacket4readER10FileSystemRNS_14EditorGameBaseERNS_15MapObjectLoaderE+0x22e)[0x5555e965943e]
./widelands(_ZN9Widelands18WidelandsMapLoader17load_map_completeERNS_14EditorGameBaseENS_9MapLoader8LoadTypeE+0x4d9)[0x5555e93fe7e9]
./widelands(_ZN9Widelands10GameLoader9load_gameEb+0x5f4)[0x5555e96e6764]
./widelands(_ZN9Widelands4Game13run_load_gameERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEES8_+0x555)[0x5555e93c30e5]
./widelands(_ZN6FsMenu8LoadGame10clicked_okEv+0x233)[0x5555e9474f63]
./widelands(+0x3c2896)[0x5555e93ce896]
./widelands(_ZN2UI5TableIPvE17handle_mousepressEhii+0xfb)[0x5555e9460dab]
./widelands(+0x44af3f)[0x5555e9456f3f]
./widelands(+0x44af3f)[0x5555e9456f3f]
./widelands(+0x44af3f)[0x5555e9456f3f]
./widelands(+0x44af3f)[0x5555e9456f3f]
./widelands(+0x44af3f)[0x5555e9456f3f]
./widelands(+0x44af3f)[0x5555e9456f3f]
./widelands(+0x44af3f)[0x5555e9456f3f]
./widelands(+0x44af3f)[0x5555e9456f3f]
./widelands(+0x44af3f)[0x5555e9456f3f]
./widelands(_ZN2UI5Panel13ui_mousepressEhii+0xc4)[0x5555e9457104]
./widelands(_ZN13WLApplication12handle_inputEPK13InputCallback+0x3ae)[0x5555e92fe21e]
./widelands(_ZN2UI5Panel6do_runEv+0x690)[0x5555e945bcb0]
./widelands(_ZN6FsMenu8MainMenu9main_loopEv+0x1a)[0x5555e947f83a]
./widelands(_ZN13WLApplication3runEv+0x600)[0x5555e9305430]
./widelands(main+0x89)[0x5555e9241d49]
/lib/x86_64-linux-gnu/libc.so.6(+0x276ca)[0x7f1ff52456ca]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0x85)[0x7f1ff5245785]
./widelands(_start+0x21)[0x5555e92f8431]
**** END BACKTRACE ****

Version:

• OS: Debian Unstable, trixie/sid 64-bit, Linux 6.6.15-amd64 x86_64
• Processor: AMD Ryzen 5 2500U with Radeon Vega Mobile Gfx × 8
• Widelands Version: see crashlog
• Enabled Add-Ons: my UI plugins test (which has a simple timer that just prints Hello World every second) and several toolbar-only editor plugins.

Additional context
A bus error? This is the first time I've ever encountered one of those :)
Such errors are usually caused by a misaligned memory access.