-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Highcharts Gantt #174
Comments
Possibly with some guidance and or startup help I could do it my self and contribute it to this great project1!? |
Hi @jvskriubakken, I would love the help if you're able! (and thanks for the kind words) Taking a quick glance at the Gantt API, it seems the general principles are the same. I imagine it could be implemented in much the same way as React JSX Highmaps is - with a single X and Y Axis. Looks like the only new things we need is a "Pathfinder" component, and new series type for Gantt (XRange already exists). |
That is great to hear @whawker ! |
Seems Gantt also includes Navigator, RangeSelector and Scrollbar functionality, I'm not sure whether we should pull these components into the Gantt package or expect users to include React JSX Highstock explicity? i.e. import { HighchartsGanttChart, Title, Subtitle } from 'react-jsx-highcharts-gantt'
import { Navigator, RangeSelector, Scrollbar } from 'react-jsx-highstock' I also wonder whether we should add a specific |
In their own example the users must explicit import from both "gantt" and highstock: This probably means that the user needs pay for both gantt and highstock to use these features together? And then it's probably wise to make the user aware of this through the import statements? My thoughts... |
Hi @whawker ! Is this something I can help with, with some guidance? I'm really interested in getting this up and running :) |
Yes I think it should be possible for you to implement this. I think maybe looking at how the React JSX Highmaps module works might be best? It might be best opening a WIP pull request so I can provide guidance during implementation? I believe the work required would be
|
Great @whawker I will start on this immediately. But the WIP pull request link you gave, did not work.... |
Fantastic! Thats odd about the link, it was this - https://ben.straub.cc/2015/04/02/wip-pull-request/ |
Maybe what you mean is that I should i create a branch from master and open a pull request immediately and commit often to this branch/pull-request? |
That's exactly what I mean, thanks @jvskriubakken |
Great! I've created a local branch "highcharts-gantt" and made some initial setup code. I'm so trying to push this to github. But it seems I am not allowed to. Am I doing something in the wrong order? Or am I not remembering my password correctly? :-) |
Maybe I must fork this repository first? |
You'll need to fork this project to your own GitHub account, then clone that repo. Then you will have correct push permission. Then you can open a PR from your fork to this project. Guide here: https://guides.github.com/activities/forking/ |
Thanks a lot for pulling the in gantt chart work and to work further on it! |
Bug or Feature Request?
Feature Request
Description
Hi guys! Is there any plans to add support Highcharts Gantt?
How to reproduce
Live demo demonstrating bug
Versions
The text was updated successfully, but these errors were encountered: