Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling the macos notch avoiding system #5338

Open
Hackder opened this issue Apr 25, 2024 · 0 comments
Open

Allow disabling the macos notch avoiding system #5338

Hackder opened this issue Apr 25, 2024 · 0 comments
Labels
enhancement New feature or request macOS Issue applies to Apple macOS

Comments

@Hackder
Copy link

Hackder commented Apr 25, 2024

Is your feature request related to a problem? Please describe.
When entering a non-native fullscreen on a macbook with a notch, wezterm attempts to avoid the notch.
I use my tabs at the bottom, and I want wezterm to render under the notch, instead of having a black bar at the top.
As far as I know there, is no way to disable the notch-avoidance system.

Describe the solution you'd like
Leaving the decision to the user would be the best option in my opinion. Having options like window_padding.
Let's say:
window_margin
get_os_recommended_padding

This would allow people to do all the possible options.

  1. Leaving it with (0, 0, 0, 0) - what I want
  2. window_margin = { top = get_os_recommended_padding().top ... - having a black bar at the top (the current)
  3. window_padding = { top = get_os_recommended_padding().top ... - terminal background overlaps notch, but the content doesn't

Describe alternatives you've considered
Adding more options like disable_notch_avoidance would defeat the purpose of having a Turing complete language for configuration. Having these API's exposed to the user would also allow for workarounds for the non perfect notch avoidance (as it is currently).
Providing the primitives and letting the user choose, (with sane defaults) is usually the best with these kinds of tools.

Additional context
These images contain the two (my, and the current) behaviors.

NOTE: The current one is bugged and doesn't avoid the notch completely, see #3807 but this is unrelated to this feature request

image
image

@Hackder Hackder added the enhancement New feature or request label Apr 25, 2024
@wez wez added the macOS Issue applies to Apple macOS label May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request macOS Issue applies to Apple macOS
Projects
None yet
Development

No branches or pull requests

2 participants