Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] WET bot is generating empty commits #40

Open
EricDunsworth opened this issue Aug 11, 2023 · 1 comment
Open

[Bug] WET bot is generating empty commits #40

EricDunsworth opened this issue Aug 11, 2023 · 1 comment

Comments

@EricDunsworth
Copy link
Member

EricDunsworth commented Aug 11, 2023

Describe the bug:
The vast majority of recent commits generated by @wet-boew-bot in this repo are empty. As in, they're just "hollow" commit messages with 0 changed files.

That might not necessarily be a bug in and of itself, but it adds lots of unnecessary bloat to the repo's commit history. Not to mention that it makes it practically impossible to find anything meaningful in GitHub's commit history section (it doesn't distinguish commits associated to changed files).

@duboisp @delisma Could the bot be updated to only generate commits when files have been changed?

Thanks :)!

To Reproduce:

  1. Visit this repo's commit history section.
  2. Visit links to recent commits. For example, here are the 3 latest ones:
  3. Review changed files.

Expected behaviour:
All commits should contain changed files.

Actual behaviour:
Many recent commits contain 0 changed files.

@duboisp
Copy link
Member

duboisp commented Aug 11, 2023

Those commit are generated by the GCWeb continuous deployment GitHub action.

Feel free to update it and submit a PR that will fix your issue. Here the code that create the commit in this repository: https://github.com/wet-boew/GCWeb/blob/master/.github/workflows/cd.yml#L105-L119

For now, I don't know when we will be able to look at this issue but we can discuss about during our weekly office hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants