Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waltz IntegrationHelper should be more generic #1

Open
whynick1 opened this issue Jul 8, 2019 · 0 comments
Open

Waltz IntegrationHelper should be more generic #1

whynick1 opened this issue Jul 8, 2019 · 0 comments

Comments

@whynick1
Copy link
Contributor

whynick1 commented Jul 8, 2019

Waltz IntegrationHelper currently makes some assumptions about a cluster setup.

i.e.

this.storageGroupMap = Utils.map(host + ":" + storagePort, STORAGE_GROUP_ID);

ZooKeeperCli.Create.createCluster(zkClient, root, "test cluster", numPartitions);
ZooKeeperCli.Create.createStores(zkClient, root, numPartitions, storageGroupMap);

The helper instance, upon starting ZK, creates znode metadata that implies there is only one storage node. A few other helper methods also assume there is only one waltz server/storage node (i.e. getServerPort(), getStoragePort(), etc.). It should be made more configurable such that the number of server/storage nodes is not presumed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant